Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fromCompletableFuture cancelation leak #3425

Merged
merged 14 commits into from
Feb 17, 2023
Merged

Fix fromCompletableFuture cancelation leak #3425

merged 14 commits into from
Feb 17, 2023
+37 −30

Conversation

armanbilge
Copy link
Member

I inadvertently took over @TimWSpence's PR #3417 😅

@armanbilge
Copy link
Member Author

Damn it. You broke it, you bought it 😩

@armanbilge
Copy link
Member Author

armanbilge commented Feb 17, 2023 •
edited
Loading

Welp. We must have some global fiber monitor state somewhere, that persists across isolated runtimes ...

Edit oh lol

cats-effect/core/jvm-native/src/main/scala/cats/effect/unsafe/FiberMonitor.scala

Lines 219 to 228 in 204fca2

private[FiberMonitor] final val BagReferences
: ConcurrentLinkedQueue[WeakReference[WeakBag[Runnable]]] =
new ConcurrentLinkedQueue()
private[FiberMonitor] final val Bags: ThreadLocal[WeakBag[Runnable]] =
ThreadLocal.withInitial { () =>
val bag = new WeakBag[Runnable]()
BagReferences.offer(new WeakReference(bag))
bag
}

@djspiewak djspiewak merged commit 33269d3 into typelevel:series/3.4.x Feb 17, 2023
@armanbilge armanbilge mentioned this pull request Oct 6, 2023
Merged
@armanbilge armanbilge mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armanbilge @djspiewak @TimWSpence